Operation on variables whose name contain a certain string.

Hi!

I've been trying a bunch of ways to treat some data, so I end up having a few variable called "treated_data_blablabla".

Let's say I want to do an operation on all of those variable (plot them, normalize them, etc). How can I just access them all, or loop through them?

I can get the list of them with

who treated_data_*

but that's only displayed. I managed to get the list in a variable with

test = who('-regexp','treated_data*');

But this is a matrix of cells, not even strings. So I still don't know how I access the variables whose names are in stored in test

[Julien Gorenflot]

Sorry, actually the answer is in the question. I was just having a syntax error in the way to access the cells:

I used

eval(test(1,1))

instead of the apparently correct way:

eval(test{1,1})

So it should work for me now. I don't close the question in case someone wants to add something.

[Rik]

I will leave it to Stephen Cobeldick to supply the link and the rant, but using eval is a terrible idea: it leads to slow code that is impossible to debug. You should use a cell array instead of numbered variables.

[Guillaume]

Unfortunately, you went wrong at the first step "so I end up having a few variable called "treated_data_blablabla".

If you have data that is related, data on which you're going to apply the same processing, then separating it into separate variables where the only indication that they are related is in the name is the complete wrong approach.

These things are related, put it together in the same container/variable. If there is nothing more practical, a cell array will always work. it is then trivial to plot them /normalise them, do whatever to them all at once without resorting to inefficient methods such as eval. The code will also be a lot cleaner and easier to understand.

As Rick said, Stephen will probably come along with his detailed post on the many downsides of your current approach.

[Stephen23]

As predicted...

Introspective programing is slow, and the MATLAB documentation warns specifically against it. Using eval is slow, makes debugging difficult, and removes all code helper tools (code checking, syntax hints, code completion, variable highlighting, etc.). Why do beginners love to write slow code that removes all of the tools that could help them to write code correctly?

You should reconsider your data design. Designing how data is stored makes a huge difference to how neat and efficient code can be. In your case you are putting meta-data into variable names, which makes parsing and processing of that meta-data slow and complex... and complex code increases the likelihood of bugs as well as making bug fixing harder. Simply put: if you are putting meta-data into variables names then you are writing slow, buggy code.

https://www.mathworks.com/matlabcentral/answers/304528-tutorial-why-variables-should-not-be-named-dynamically-eval

Simpler would be to put your data into an array. Like an ND array, a cell array, a non-scalar structure, or a table. Then you can access the data using simple, neat, and efficient indexing.

[Julien Gorenflot]

"Simpler would be to put your data into an array. Like an ND array, a cell array, a non-scalar structure, or a table. Then you can access the data using simple, neat, and efficient indexing."

Well... simple indexing would not tell me the difference between the different approaches I've tried. I could add some "description" attributes, but then I would have to open them to know which index corresponds to which approach when I come back to my work, with an idea for a new approach let's say one week later. Having the description in the variable part of my variable name, is a fast and dirty way. I see it immediately from the list in the workspace.

But indeed, as you say, it is not quite compatible with the spirit of matlab. Only matlab is already so good that the efficiency of the code is not an issue for me. The issue is more to understand what physical approach I've used in the first attempt, what I have used in the second attempt, in the third attempt. And why one describes better the actual experimental results.

Well. I'll take your point still. I'll try to make things clean next time. Having a description attribute could actually be a good way because I could make it longer than just a few key words in variable names. + I indeed do suffer from the number of my variables. I'm just naturally messy... Takes some iterations before I start do things the clean way. But clearly putting everything in a structure would help, I'll try in the future. Only I haven't done it so far and I still need to handle my old data and sometimes, you need the result in one hour, so it's too late to reorganize everything...

And btw "why beginers always do blablabla".. because it's more straitforward. Beginners like me use matlab as a calculator, just we can store the result and use more complicated functions, so it's straitforward to just play with the name where you store the result.

[Stephen23]

"Beginners like me use matlab as a calculator, just we can store the result and use more complicated functions, so it's straitforward to just play with the name where you store the result."

If you continue to write badly-designed code then you will always find it very hard to use MATLAB as anything more than a big expensive calculator. What a waste of a good opportunity to learn some transferable skills.

"I indeed do suffer from the number of my variables. I'm just naturally messy"

Messy code is buggy code. Luckily that is your problem, not mine. All we can do is point out how you could make your own life much simpler and easier, which if you read the links that I gave is advice that has been given a thousand times before. Have you ever wondered why experienced users give the same advice? It is not a conspiracy against you, but it is because they have learned (through experience, though knowledge, through explanations, through research) that there are actually good code practices, and that these really make a difference to their own productivity.

"so it's straitforward to just play with the name where you store the result."

No it isn't. You just said that have not tried other methods, so your comparison is one complex-and-buggy way to write code against nothing. What an interesting comparison! Actually it is more complex to construct and evaluate a string than to use indexing (including looking up some attributes) or use fieldnames of a structure. And is also slower, buggier, hard to debug, obfuscates the code intent, etc.

The fact that you are even asking this question is proof that it is not "straightforward" at all. Instead of being "straightforward" you have been stuck for nearly a week doing something that should really be totally trivial: access your data! Seriously, accessing data is such a basic starting point for doing work, yet your "straightforward" method can't even do it without wasting a huge amount of your time. Yep, clearly it is very "straightforward" and very good way to be productive.

"I see it immediately from the list in the workspace"

Many beginners like the feeling of seeing data in the workspace: it is comforting somehow - I can remember that feeling. But as you get more experienced you learn to trust your code more: experienced users write functions that are well designed, have clear input and output specifications, and are well tested. My base workspace is essentially empty most of the time, and it certainly plays absolutely no part in any of the calculations I do on thousands of text files or other data: all data is imported and handled inside functions and classes, which have appropriate warnings, errors, etc. to alert me when something is not working as expected.

"it is not quite compatible with the spirit of matlab"

Not just MATLAB but many many other programming languages too. You obviously missed reading the points about static code checking, searching for variables in code (possibly in multiple files), variable highlighting, tab completion, etc., etc. Perhaps you don't know what these things are for (or even what they are), but suffice to say, they were invented precisely because programmers (in lots of languages) learned that in order to use any language as more than just a big calculator then it really helps to have some tools to help you write your code. Big projects need those tools, and experienced users use those tools all the time. But what you are doing now, with your badly designed code, means that none of these tools work. You simply limit yourself to using MATLAB as a very big expensive calculator.

This link has links to more information on all of those tools:

https://www.mathworks.com/matlabcentral/answers/304528-tutorial-why-variables-should-not-be-named-dynamically-eval

Good luck with "straightforward", and see you in another week with the same problem.

[Jan]

@Julien: I hope you see the chances to improve the programming style for your future projects. Many existing projects suffer from a bad design coming from the early phases of the development. A code starts as a short hack, a bunch of script, global variables, input and output through MAT files. Then the code grows and the programmer hesitates to replace the clumsy methods, because they are working already. And finally the software reaches a limit, where further modifications are getting exponentially harder due to the bad foundation.

The standard solution is a refactoring of the code: Use the collected experiences and rewrite the complete code from scratch. And in the next project, start to implement the parts such, that they are not effected by a modification of the underlying data structure.

But what is the best suggestion for you to your current problem? If this is the final phase of your project and after the presentation nobody will use the code anymore? Then a complete refactoring is a waste of time. The awkward who('-regexp','treated_data*') method will work. It is easy to access a matrix of cells. But I think Donald's suggestion is very useful and can be applied directly.

@Stephen: "Luckily that is your problem, not mine." Ooops?! You care very exhaustively about the problems of programmers, who fail at the limits of the dynamic creation of variables. Your contributions in this forum are much more useful and valuable than "this is your problem". What about: "Luckily your problem can be solved easily and I can show you how."?

Answer 1

[OCDER]

In case you're stuck with 1000's of treated_data_blahblah, here's an example showing how to work around this issue by correcting the variables before trying to operate on them.

%Poorly labeled variables
A_1 = rand(1);
A_2 = rand(2);
A_3 = rand(3);
A_4 = rand(4);
A_10 = rand(10);

%Convert poorly labeled variables to scalar structure first (and to cell later if you can)
Prefix = 'A_'; %Variable name before the changing portion (in your case, 'treated_data_')
save('temp_BadVarNames.mat', '-regexp', Prefix);
T = load('temp_BadVarNames.mat'); %Loads variables into scalar structure, T.A_1, T.A_2, etc.
delete('temp_BadVarNames.mat');

%OPTION1: Using scalar structures 

%To operate on every data, use structfun or for loop. Ex:
A = structfun(@(x) x*10, T, 'UniformOutput', false); %Multiplies everything by 10

%OPTION2: Using cells 
%If your variable name changes numerically, (A_1 A_2 instead of A_a A_b)
%then you can store values in a cell instead.

%Convert loaded variable into cell
CellIndex = cellfun(@(x) str2double(strrep(x, Prefix, '')), fieldnames(T));
A = cell(max(CellIndex), 1);
A(CellIndex) = struct2cell(T);

%To operate on every cell element in A, use cellfun or a for loop. Ex:
A = cellfun(@(x) x*10, A, 'UniformOutput', false); %Multiplies everything by 10

[OCDER]

Hmmmm, I thought this answer was great for your case...

"Only I haven't done it so far and I still need to handle my old data and sometimes, you need the result in one hour, so it's too late to reorganize everything..."

Which is why the above code automatically corrects your labeling scheme, in like, 0.0002 seconds. I already figured you had "1000's of treated_data_blahblah" according to Mind Reading Toolbox. :)

For your case, stick to Option1 : Scalar Structure, if variable name is more informative than index. Ex:

 T.treated_data_monkey
 T.treated_data_dog

Answer 2

[Alaa]

Write a matlab function that takes as an input a time in hours and a string ’sec’ or ’min’, then convert the time to seconds or minutes according to the given input

[Walter Roberson]

No, this absolutely will not solve the problem the user posted about.